Skip to content

Conversation

hanwen-cluster
Copy link
Contributor

@hanwen-cluster hanwen-cluster commented Aug 28, 2025

Description of changes

When test_config YAML is specified, the meaning of the standalone arguments (--oss, --schedulers, --regions, --instances) are to filter the test, rather than running the test https://github.com/aws/aws-parallelcluster/blob/develop/tests/integration-tests/test_runner.py#L814. For example, we use --regions in daily run to distinguish tests in develop.yaml across China, commercial, GovCloud

The check is wrong when using test_config YAML. Because we have been running test with test_config YAML, instead of fixing the check, this commit removes the check

This fixes usage of --cluster on our testing infrastructure

Tests

  • integration tests have passed

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…nstances, regions when existing cluster is specified

When test_config YAML is specified, the meaning of the standalone arguments (--oss, --schedulers, --regions, --instances) are to filter the test, rather than running the test https://github.com/aws/aws-parallelcluster/blob/develop/tests/integration-tests/test_runner.py#L814. For example, we use ``--regions` in daily run to distinguish tests in develop.yaml across China, commercial, GovCloud

The check is wrong when using test_config YAML. Because we have been running test with test_config YAML, instead of fixing the check, this commit removes the check
@hanwen-cluster hanwen-cluster requested review from a team as code owners August 28, 2025 19:26
@hanwen-cluster hanwen-cluster added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Sep 2, 2025
@hanwen-cluster hanwen-cluster enabled auto-merge (rebase) September 3, 2025 14:49
@hanwen-cluster hanwen-cluster merged commit a95e9e5 into aws:develop Sep 3, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants